Skip to content

[DOCS] Update applies_to tags in Docs for Sparse Vector Mapping / Index Options #130548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

[DOCS] Update applies_to tags in Docs for Sparse Vector Mapping / Index Options #130548

merged 2 commits into from
Jul 3, 2025
+6 −6

Conversation

@markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Jul 3, 2025 •
edited by leemthompo
Loading

Follow on to #129089

Updates the applies_to labels in the docs for the sparse vector index options / token pruning configurations as these features are in GA, not preview.

@markjhoy markjhoy requested a review from a team July 3, 2025 13:12
@markjhoy markjhoy added >docs General docs changes auto-backport Automatically create backport pull requests when merged Team:SearchOrg Meta label for the Search Org (Enterprise Search) :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0 v9.1.1 labels Jul 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025 •
edited
Loading

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search - Relevance The Search organization Search Relevance team v9.2.0 and removed Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Jul 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025 •
edited
Loading

🔍 Preview links for changed docs

kderusso
kderusso reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about notations here - could you please help me understand the right path forward? thanks!

docs/reference/elasticsearch/mapping-reference/sparse-vector.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @leemthompo can answer this better but do we still want the applies to, but just not the preview notation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct @kderusso the applies_to tags are what we need to distinguish features that aren't available in 9.0, it's not just about flagging their lifecycle

So basically if something new arrives in a minor, it needs applies_to and the docs are now cumulative: we don't delete information, we add information and mark it up appropriately.

We don't have a separate page for 9.0, 9.1, 9.2 etc. so we need this because it's all one page :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr @markjhoy you need to maintain the applies_to's but just s/preview/ga/g

@markjhoy markjhoy requested review from kderusso and leemthompo July 3, 2025 15:21
kderusso
kderusso approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@leemthompo leemthompo changed the title Remove Preview Labels in Docs for Sparse Vector Mapping / Index Options [DOCS] Update applies_to tags in Docs for Sparse Vector Mapping / Index Options Jul 3, 2025
leemthompo
leemthompo approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markjhoy markjhoy merged commit 8f0c3eb into elastic:main Jul 3, 2025
9 checks passed
markjhoy added a commit to markjhoy/elasticsearch that referenced this pull request Jul 3, 2025
@markjhoy
[DOCS] Update applies_to tags in Docs for Sparse Vector Mapping / Ind…
3278f33 
…ex Options (elastic#130548)

* remove preview labels docs / sparse vector type

* re-add applies to, set to ga
@markjhoy markjhoy mentioned this pull request Jul 3, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.1

elasticsearchmachine pushed a commit that referenced this pull request Jul 3, 2025
@markjhoy
[DOCS] Update applies_to tags in Docs for Sparse Vector Mapping / Ind…
253889e 
…ex Options (#130548) (#130570)

* remove preview labels docs / sparse vector type

* re-add applies to, set to ga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leemthompo leemthompo leemthompo approved these changes

@kderusso kderusso kderusso approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Docs Meta label for docs team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v9.1.0 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markjhoy @elasticsearchmachine @leemthompo @kderusso